Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes for Tycho UI and ports from Wondergem to Tycho. #868

Merged
merged 17 commits into from
Jun 28, 2021

Conversation

andyHa
Copy link
Member

@andyHa andyHa commented Jun 28, 2021

No description provided.

andyHa added 17 commits June 28, 2021 11:07
This is used to customize and also remove some history entries. As the
"real" history API doesn'T support skipping or removing history entries
(e.g. for routes like "/.../new", we install a custom history stack
stored in the localStore.

If this fails, we resort the the normal history.

Note that we also provide a "t:backButton" tag, which only shows the
back button if there is a app-local URI to go back to. This permits to
show an "intelligent" back button for the 404 page.
For everything else, we use a common <h5 class="card-title">..</h5>.
Without setting this, there is no proper width calculated and the
overflow-x attributes within the cards (e.g. to limit the title or to
add a scrollbar to a card) wouldn't work.
This will be made visible by history.js if there is a app-local URI
to "go back to".
Note that just like t:backButton this is still only shown, if there
is an app-local URI to go back to.
Without the flew-grow, the main content woudldn't use the available
screen real estate.
* http://www.scireum.de - info@scireum.de
*/

.bl-gray {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Maybe add a .b-gray that sets it for all directions

@andyHa andyHa merged commit 3da0083 into develop Jun 28, 2021
@andyHa andyHa deleted the feature/aha/misc-enhancements branch June 28, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants