-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes for Tycho UI and ports from Wondergem to Tycho. #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to customize and also remove some history entries. As the "real" history API doesn'T support skipping or removing history entries (e.g. for routes like "/.../new", we install a custom history stack stored in the localStore. If this fails, we resort the the normal history. Note that we also provide a "t:backButton" tag, which only shows the back button if there is a app-local URI to go back to. This permits to show an "intelligent" back button for the 404 page.
For everything else, we use a common <h5 class="card-title">..</h5>.
Without setting this, there is no proper width calculated and the overflow-x attributes within the cards (e.g. to limit the title or to add a scrollbar to a card) wouldn't work.
This will be made visible by history.js if there is a app-local URI to "go back to".
Note that just like t:backButton this is still only shown, if there is an app-local URI to go back to.
Without the flew-grow, the main content woudldn't use the available screen real estate.
sabieber
approved these changes
Jun 28, 2021
* http://www.scireum.de - info@scireum.de | ||
*/ | ||
|
||
.bl-gray { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: Maybe add a .b-gray
that sets it for all directions
qw3ry
approved these changes
Jun 28, 2021
idlira
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.