Properly supports barcodes for GTIN-14 using the ITF format #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 25, 2021 11:54
This is commonly used to create barcodes for GTINs with 14 digits used for certain types of packaging (see https://en.wikipedia.org/wiki/ITF-14). Fixes: SIRI-487
…with format type "ean". Fixes: SIRI-487
Fixes: SIRI-487
Fixes: SIRI-487
sabieber
approved these changes
Nov 25, 2021
Fixes: SIRI-487 Co-authored-by: Sascha Bieberstein <sabieber@users.noreply.github.com>
Fixes: SIRI-487
sabieber
approved these changes
Nov 25, 2021
added 7 commits
November 29, 2021 10:27
for all types except the special interleaved2of5checksummed Fixes: SIRI-487
Fixes: SIRI-487
Fixes: SIRI-487
Fixes: SIRI-487
Fixes: SIRI-487
Fixes: SIRI-487
Fixes: SIRI-487
cschierle
changed the title
Fixes: SIRI-487
sabieber
reviewed
Nov 29, 2021
src/main/java/sirius/web/templates/pdf/handlers/BarcodePdfReplaceHandler.java
Outdated
Show resolved
Hide resolved
Fixes: SIRI-487
fhaScireum
approved these changes
Nov 29, 2021
jmuscireum
reviewed
Nov 29, 2021
src/main/java/sirius/web/templates/pdf/handlers/BarcodePdfReplaceHandler.java
Outdated
Show resolved
Hide resolved
added 5 commits
November 29, 2021 14:27
Scaling is done via css. Fixes: SIRI-487
…cksum beforehand Fixes: SIRI-487
This was only needed to produce a base image of sufficient size with the previous barcode library. Scaling is done via css. Fixes: SIRI-487
…ehavior is also uniform Fixes: SIRI-487
fhaScireum
approved these changes
Nov 29, 2021
idlira
approved these changes
Nov 29, 2021
sabieber
approved these changes
Nov 29, 2021
andyHa
approved these changes
Nov 29, 2021
jmuscireum
reviewed
Nov 29, 2021
jmuscireum
reviewed
Nov 29, 2021
added 2 commits
November 29, 2021 15:49
Fixes: SIRI-487
…esolution for scaling. Fixes: SIRI-487
jmuscireum
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is commonly used to create barcodes for GTINs with 14 digits used for certain types of packaging (see https://en.wikipedia.org/wiki/ITF-14).
BarcodePdfReplaceHandlerandBarcodeControllernow both usezxingto generate barcodes.NOTE:
BarcodePdfReplaceHandlerdid generate barcodes for such GTINs, but they were unreliable when scanning.Example:
The previous PDF replace produced a barcode for
<img src="barcode://ean/12345678987654"/>, that cannot be reliably resolved back to "12345678987654":With these changes, the produced barcode looks like this and can be scanned reliably:
Fixes: SIRI-487