Embed SVG delete button icon in an IE 11 compatible way #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE11 doesn't seem to like utf-8 embedded SVGs as background images, so we switch to base64 encoding them. Fixes: OX-11077
sabieber
added
🐛 Bugfix
ymo-sci
approved these changes
Jun 25, 2024
idlira
approved these changes
Jun 25, 2024
fhaScireum
approved these changes
Jun 25, 2024
sabieber
added a commit
to scireum/sirius-web
that referenced
this pull request
Jun 25, 2024
This include the fix of scireum/token-autocomplete#83 Fixes: OX-11077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IE11 doesn't seem to like utf-8 embedded SVGs as background images, so we switch to base64 encoding them.
Before:
After:
Additional Notes
Checklist