Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to handle DOIs with unusual characters #51

Closed
smackesey opened this issue May 9, 2018 · 3 comments
Closed

Fails to handle DOIs with unusual characters #51

smackesey opened this issue May 9, 2018 · 3 comments
Milestone
v0.5.2

Comments

@smackesey
Copy link

This fails:

Serrano.works(ids: '10.1002/1096-9861(20010212)430:3<283::aid-cne1031>3.0.co;2-v')

But this works:

encoded_doi = ERB::Util.url_encode('10.1002/1096-9861(20010212)430:3<283::aid-cne1031>3.0.co;2-v')
Serrano.works(ids: encoded_doi)

Serrano should probably perform this URL encoding for the user.
@sckott
Copy link
Owner

sckott commented May 9, 2018

Thanks for this @smackesey

I agree we should probably do the url encoding

@sckott sckott added this to the v0.6 milestone May 9, 2018
sckott added a commit that referenced this issue May 9, 2018
@sckott
#51 url encode DOIs and other Ids (just in case) for most methods exc…
fc71978 
…ept citation count

bump patch version
add tests for url encoding
add to docs notes about url encoding and what method used to do so
@sckott
Copy link
Owner

sckott commented May 9, 2018

@smackesey can you reinstall from github and try again ?

@smackesey
Copy link
Author

I tried with the latest commit from master and it now works. Thanks!

@sckott sckott closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.2
Development

No branches or pull requests
2 participants
@sckott @smackesey