Reference working websocket.io branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close markserv#19 In commit b449a88 ("Use a specific unreleased commit of Website.io until it get released later.", 2017-01-17) we needed an unreleased fix to websocket.io. It seems that either GitHub or NPM has lost the option to reference commits linked through another fork. This fixes markserv#19 by referencing the original author's branch. This unreleased version is required because websocket.io is broken on Node 7+. Unfortunately it seems that the websocket.io authors no longer are interested in keeping their package Node 7+ compatible. (Discussion at LearnBoost/websocket.io#57). There still exists the following caveats: * If @kewisch wishes to remove his fork then this will no longer work * Official support seems lacking * This program is dependent on an unstable package I suggest investigating the possibility of using an alternative websocket package with less problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close markserv#19
In commit b449a88 ("Use a specific unreleased commit of Website.io until
it get released later.", 2017-01-17) we needed an unreleased fix to
websocket.io. It seems that either GitHub or NPM has lost the option to
reference commits linked through another fork. This fixes markserv#19 by
referencing the original author's branch.
This unreleased version is required because websocket.io is broken on
Node 7+. Unfortunately it seems that the websocket.io authors no longer
are interested in keeping their package Node 7+ compatible. (Discussion
at LearnBoost/websocket.io#57).
There still exists the following caveats:
I suggest investigating the possibility of using an alternative
websocket package with less problems.