-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitLab for syncing upstream->downstream - gitlab_git_changes #71
Conversation
71ee162
to
7316654
Compare
/test |
2963e06
to
f74b7e9
Compare
/test |
Before I get into the details I have a suggestion - how about making the gitlab module an extension of the distgit module and only modifying what is necessary to change? I expect a lot of the functionality would stay the same (just with different server and APIs) or could be changed to be more configurable. |
Thanks for this comment. I think more functions like We can make GitLab module on the top of distgit module, but I would prefer to use dist-git module only for cloning downstream (dist-git), building, and GitLab module for operation with upstream -> downstream. |
d221fd2
to
3d967ce
Compare
@pkubatrh Feel free to review it a bit. |
The pull request can be reviewed. I would be glad for you feedback. /test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first quick scan. I won't have time for that sooner than after devconf.
This pull request allows using gitlab for syncing upstream->downstream. The rest of function remains. Like git clonedownstream uses dist-git Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
gitlab.py was moved to internal repository. There are some integrations like Slack, that are private. /test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next round of review. I'm not a user of this tool so I might miss the big picture but I spot some potential improvements.
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
There are no-compatible changes Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
/test |
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
/test |
@pkubatrh @frenzymadness Hi folks, I have addressed all issues, If you have nothing against merging, I would like to merge it, so I can work on RHCWT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to go.
This pull request allows using gitlab for
syncing upstream->downstream.
The rest of the function remains. Like
git clonedownstream uses dist-git.
This pull request covers 'git pullupstream', 'git show', and 'git push'.
The GitLab functionality is valid only for RHEL and RHCWT especially. CWT itself does not make sense for this.
The question is if 'gitlab.py' should be in CWT or should be moved to RHCWT, like 'bugzilla.py' or 'jira.py'
The calling is like this:
Signed-off-by: Petr "Stone" Hracek phracek@redhat.com