Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests reuse cached container even if container build for test group failed #444

Closed
SlouchyButton opened this issue Aug 15, 2024 · 0 comments · Fixed by #445
Closed

Tests reuse cached container even if container build for test group failed #444

SlouchyButton opened this issue Aug 15, 2024 · 0 comments · Fixed by #445
Assignees
@SlouchyButton

Comments

@SlouchyButton
Copy link
Contributor

It seems that the issue from ruby s2i container is also applicable here.

Ref: sclorg/s2i-ruby-container#557

It seems we are not clearing built sample app images between tests.
@SlouchyButton SlouchyButton self-assigned this Aug 15, 2024
SlouchyButton added a commit to SlouchyButton/s2i-nodejs-container that referenced this issue Aug 28, 2024
@SlouchyButton
Check whether build passes. Do not reuse builds across tests.
16dd894 
Fixes: sclorg#444
SlouchyButton added a commit to SlouchyButton/s2i-nodejs-container that referenced this issue Aug 28, 2024
@SlouchyButton
Check whether build passes. Do not reuse builds across tests.
04cafd5 
Fixes: sclorg#444
@SlouchyButton SlouchyButton mentioned this issue Aug 28, 2024
Merged
SlouchyButton added a commit to SlouchyButton/s2i-nodejs-container that referenced this issue Sep 30, 2024
@SlouchyButton
Check whether build passes. Do not reuse builds across tests.
b37e426 
Fixes: sclorg#444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SlouchyButton SlouchyButton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check whether build passes. Do not reuse builds across tests. SlouchyButton/s2i-nodejs-container
1 participant
@SlouchyButton