Fix assemble cache clean order in 16-minimal, 18-minimal #459
Conversation
Removal of the cache has to be the last things done in the assemble script. Calling `npm` after deleting the cache folder will cause npm to recreate it - which will fail during the image test.
|
[test] |
Pull Request validationFailed🔴 Failed or pending statuses - Success🟢 Review - Reviewed by undefined |
afaik two approvals are needed, and it's not yet merging automatically, only sending email that it would. |
|
@lukaszachy @SlouchyButton Automatic merger is not enabled yet;). Don't worry. See send only mails about PR and what is missing. Syncing upstream -> downstream for RHEL-9.5.0 is also disabled. |
It's hard to test it completely as this issue is present (for some unknown reason) only in the konflux built image, but as far as I tested it, it should resolve the error. Also, the issue was present only in 16-min and 18-min - this change changes the code to be identical with other version. For some reason, these two containers had the tmp clean and cache clean reversed. |
|
[test] |
Testing Farm results
|
Removal of the cache has to be the last things done in the assemble script. Calling
npmafter deleting the cache folder will cause npm to recreate it - which will fail during the image test.Other images apparently have it correctly, for some reason this error is present only in 16-minimal and 18-minimal.