Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building and testing s2i-python-container on RHEL10 host #727

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Support building and testing s2i-python-container on RHEL10 host #727

merged 3 commits into from
Jan 27, 2025
+133 −0

Conversation

phracek
Copy link
Member

@phracek phracek commented Jan 24, 2025 •
edited by github-actions bot
Loading

This pull request adds support for building and testing s2i-python-container on RHEL10 host.

The pull request is separated into three commit:

  • the first adds support for building container in RHEL10 to spec files
  • The second commit adds distgen generated files
  • the third commit updates README.md file

@phracek
Copy link
Member Author

phracek commented Jan 24, 2025

[test]

@phracek phracek force-pushed the building_testing_rhel10 branch from b540a33 to aa24567 Compare January 27, 2025 08:15
@phracek
Copy link
Member Author

phracek commented Jan 27, 2025

Test after rebase against master

[test]

@phracek
Copy link
Member Author

phracek commented Jan 27, 2025

GitHub action was updated to the latest. But, I do not know if this should be a separated pull request or not.
Let's test it by shot.

[test]

@frenzymadness
Copy link
Member

Let me take a look what is wrong with the distgen here.

@phracek
Copy link
Member Author

phracek commented Jan 27, 2025

This is blocked by #728

@phracek phracek force-pushed the building_testing_rhel10 branch from 71ba40a to 4fe6e5f Compare January 27, 2025 10:41
@phracek
Copy link
Member Author

phracek commented Jan 27, 2025

Rebased against master. The issue #728 was merged.

[test]

@github-actions GitHub Actions
Copy link

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
RHEL8 - 3.11RHEL-8.10.0-Nightlyx86_64⛔ infra error27.01.2025 10:43:128min 51stest pipeline

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
RHEL9 - 3.11RHEL-9.4.0-Nightlyx86_64✅ passed27.01.2025 13:16:3027min 26stest pipeline
RHEL8 - 3.11-minimalRHEL-8.10.0-Nightlyx86_64✅ passed27.01.2025 13:16:2727min 12stest pipeline
RHEL8 - 3.12RHEL-8.10.0-Nightlyx86_64✅ passed27.01.2025 13:16:2831min 19stest pipeline
RHEL9 - 3.12RHEL-9.4.0-Nightlyx86_64✅ passed27.01.2025 13:16:2926min 15stest pipeline
RHEL8 - 3.12-minimalRHEL-8.10.0-Nightlyx86_64✅ passed27.01.2025 13:16:3825min 49stest pipeline
RHEL10 - 3.12-minimalRHEL-10-Nightlyx86_64✅ passed27.01.2025 13:16:3823min 1stest pipeline
RHEL9 - 3.12-minimalRHEL-9.4.0-Nightlyx86_64✅ passed27.01.2025 13:16:3824min 58stest pipeline
RHEL9 - 3.9RHEL-9.4.0-Nightlyx86_64✅ passed27.01.2025 13:33:2725min 49stest pipeline
RHEL8 - 3.9RHEL-8.10.0-Nightlyx86_64✅ passed27.01.2025 13:17:2129min 56stest pipeline
CentOS Stream 10 - 3.12CentOS-Stream-10x86_64✅ passed27.01.2025 13:16:2818min 34stest pipeline
CentOS Stream 9 - 3.11CentOS-Stream-9x86_64✅ passed27.01.2025 13:16:2819min 24stest pipeline
RHEL8 - 3.9-minimalRHEL-8.10.0-Nightlyx86_64✅ passed27.01.2025 13:35:0124min 32stest pipeline
CentOS Stream 9 - 3.11-minimalCentOS-Stream-9x86_64✅ passed27.01.2025 13:16:2818min 2stest pipeline
CentOS Stream 10 - 3.12-minimalCentOS-Stream-10x86_64✅ passed27.01.2025 13:16:2916min 12stest pipeline
CentOS Stream 9 - 3.12CentOS-Stream-9x86_64✅ passed27.01.2025 13:16:2619min 37stest pipeline
Fedora - 3.12Fedora-latestx86_64✅ passed27.01.2025 13:16:3122min 21stest pipeline
CentOS Stream 9 - 3.12-minimalCentOS-Stream-9x86_64✅ passed27.01.2025 13:16:3117min 40stest pipeline
Fedora - 3.12-minimalFedora-latestx86_64✅ passed27.01.2025 13:16:3619min 55stest pipeline
CentOS Stream 9 - 3.9CentOS-Stream-9x86_64✅ passed27.01.2025 13:16:5618min 58stest pipeline
CentOS Stream 9 - 3.9-minimalCentOS-Stream-9x86_64✅ passed27.01.2025 13:17:2617min 4stest pipeline
Fedora - 3.13Fedora-latestx86_64✅ passed27.01.2025 13:16:3722min 9stest pipeline
RHEL8 - 3.11RHEL-8.10.0-Nightlyx86_64✅ passed27.01.2025 13:16:2829min 36stest pipeline

@frenzymadness
Copy link
Member

One more rebase please.

@phracek phracek force-pushed the building_testing_rhel10 branch from 4fe6e5f to 6ee4ff4 Compare January 27, 2025 12:06
@phracek
Copy link
Member Author

phracek commented Jan 27, 2025

Rebased

[test]

@phracek
Adds support for building python 3.12-minimal container for RHEL10.
e4bcb11 
To multispec.yaml is added section about rhel10 and
build it 3.12-minimal on RHEL10

manifest-minimal.yml is updated to add Dockerfile.rhel10

base image is ubi10-minimal:latest

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Add dist-gen generated sources
d34287a 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Update main README.md file with support RHEL10
f73433e 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the building_testing_rhel10 branch from 6ee4ff4 to f73433e Compare January 27, 2025 13:14
@phracek
Copy link
Member Author

phracek commented Jan 27, 2025

The base image was wrong. Instead of ubi10/ubi-minimal it is ubi10-minimal

[test]

frenzymadness
frenzymadness approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and the results are green. Although I don't see the results of all the tests in the log.

@phracek phracek merged commit adde84a into master Jan 27, 2025
23 checks passed
@phracek phracek deleted the building_testing_rhel10 branch January 27, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzymadness frenzymadness frenzymadness approved these changes

Assignees
No one assigned
Labels
READY-to-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phracek @frenzymadness