Create GitHub comment summary report from Testing Farm results #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
jamacku
reviewed
Jul 22, 2024
| @@ -0,0 +1,92 @@ | |||
| import { getInput } from '@actions/core'; | |||
| import { context } from '@actions/github'; | |||
| import MetadataController from 'issue-metadata'; | |||
There was a problem hiding this comment.
You have to add issue-metadata to the list of dependencies - yarn add issue-metadata
jamacku
reviewed
Jul 22, 2024
|
|
||
| set dateTimeInfo(value: MetadataObject['TFDatetime']) { | ||
| this._TFDatetime = value; | ||
| } |
There was a problem hiding this comment.
I would personally avoid using setters and getters. They make code unreadable.
| ) { | ||
| this._TFcommentID = metadata?.TFCommentID ?? undefined; | ||
| this._TFDatetime = metadata?.TFDatetime ?? undefined; | ||
| this._TFSummaryInfo = metadata?._TFSummaryInfo ?? []; |
There was a problem hiding this comment.
You are missing the declarations for _TFDatetime and _TFSummaryInfo.
| }, | ||
| }); | ||
|
|
||
| const parsedCommentID = z |
There was a problem hiding this comment.
Please move the validation scheme into schema/ dir.
| @@ -14,12 +15,33 @@ export class PullRequest { | |||
| * @param sha - The head sha of the Pull Request | |||
| * @param octokit - The Octokit instance to use for interacting with the GitHub API | |||
| */ | |||
| private _metadata: Metadata | undefined; | |||
There was a problem hiding this comment.
Please move metadata property into constructor and make it readonly instead of private
jamacku
changed the title
2 tasks
|
Thanks for the great work. I took over in PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements showing all statuses as comment.