Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path encoding when working with files #42

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Fix path encoding when working with files #42

merged 3 commits into from
Sep 13, 2021

Conversation

fscholdei
Copy link
Member

@fscholdei fscholdei commented Sep 8, 2021 •
edited
Loading

Proposed changes

Fix path encoding when working with files.

The encoding of breadcrumb and code section has been fixed with scm-manager/scm-manager#1776.

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@fscholdei fscholdei added the bug Something isn't working label Sep 8, 2021
eheimbuch
eheimbuch reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@eheimbuch eheimbuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

src/main/js/Edit/encodeFilePath.ts Show resolved Hide resolved
@eheimbuch
Copy link
Contributor

eheimbuch commented Sep 10, 2021 •
edited
Loading

The filename is decoded on most occurrences, but not on the breadcrumb.
breadcrumd_encoding

@eheimbuch eheimbuch merged commit 7f7b2a8 into develop Sep 13, 2021
@eheimbuch eheimbuch deleted the bugfix/encode_path branch September 13, 2021 06:16
@scm-manager scm-manager deleted a comment from eheimbuch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eheimbuch eheimbuch eheimbuch left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fscholdei @eheimbuch