Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix over fetching of content type #47

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix over fetching of content type #47

merged 2 commits into from
Oct 11, 2021

Conversation

sdorra
Copy link
Member

@sdorra sdorra commented Oct 8, 2021

Proposed changes

Use hook of @scm-manager/ui-api to fetch the content type in order to avoid multiple fetches of the content type.

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@sdorra sdorra added the bug Something isn't working label Oct 8, 2021
@fscholdei fscholdei merged commit 86109c3 into develop Oct 11, 2021
@fscholdei fscholdei deleted the bugfix/content_type_overfetching branch October 11, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fscholdei fscholdei fscholdei approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdorra @fscholdei