Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve modal accessibility #60

Merged
merged 9 commits into from
Jan 24, 2022
Merged

Conversation

Pilopa
Copy link
Contributor

@Pilopa Pilopa commented Jan 20, 2022

Proposed changes

This PR uses core changes to improve modal accessibility.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@Pilopa Pilopa marked this pull request as ready for review January 20, 2022 08:12
@Pilopa Pilopa added the enhancement New feature or request label Jan 20, 2022
@Pilopa Pilopa changed the title Implement initial focus for modals Improve modal accessibility Jan 20, 2022
@matthiasthieroff matthiasthieroff merged commit 769b8f2 into develop Jan 24, 2022
@matthiasthieroff matthiasthieroff deleted the feature/modal-focus branch January 24, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants