Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vertical scrolling for smaller screens #73

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

fscholdei
Copy link
Member

@fscholdei fscholdei commented Mar 30, 2022

Proposed changes

On smaller screens, the horizontal scrollbar in the fullscreen view is only displayed when editing a file as soon as the user scrolls all the way down in the modal. Otherwise, the user can only navigate horizontally using a touchpad or keyboard. With this change, the vertical scrollbar should always be displayed.

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New/updated ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@fscholdei fscholdei added the bug Something isn't working label Mar 30, 2022
@fscholdei fscholdei changed the title Improve vertical scrolling experience for smaller screens Improve vertical scrolling for smaller screens Mar 30, 2022
@fscholdei fscholdei force-pushed the bugfix/vertical_scrolling branch from e59e449 to 7e91f0e Compare March 30, 2022 12:51
@matthiasthieroff matthiasthieroff merged commit 56b436e into develop Mar 30, 2022
@matthiasthieroff matthiasthieroff deleted the bugfix/vertical_scrolling branch March 30, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants