Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert .grouped to return an Iterator instead of a Stream? #55

Closed
lihaoyi opened this issue Sep 10, 2016 · 1 comment
Closed

Convert .grouped to return an Iterator instead of a Stream? #55

lihaoyi opened this issue Sep 10, 2016 · 1 comment
Milestone

Comments

@lihaoyi
Copy link

lihaoyi commented Sep 10, 2016

That would better match up with the collections in the standard library, which all return Iterator. Current inefficient workaround is .toArray.grouped.map(ByteVector.view), though with a bit more boilerplate less wasteful version could be written

@mpilquist
Copy link
Contributor

👍 for either 1.2 or 2.0 -- whatever comes next. Let's keep this issue open until we decide breaking binary compatibility makes sense.

@mpilquist mpilquist added this to the 1.2 milestone Sep 21, 2016
mpilquist added a commit that referenced this issue Jan 18, 2019
Fixed #55 by deprecating grouped and replacing with groupedI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants