Add 'name' and 'mode' arguments to LuaRuntime.{eval,execute,compile} #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to allow finer control of input and debug output. Closes #248
astoff
reviewed
Dec 10, 2023
| """Run Lua code with arguments""" | ||
| cdef lua_State* L = runtime._state | ||
| cdef const char* c_name = b'<python>' |
There was a problem hiding this comment.
This line I would change to
Suggested change
| cdef const char* c_name = b'<python>' | |
| cdef const char* c_name = b'=<python>' |
or
Suggested change
| cdef const char* c_name = b'<python>' | |
| cdef const char* c_name = NULL |
for the reason explained here.
There was a problem hiding this comment.
I've seen your comment but it would introduce an incompatible change. It would break doctests, for example, or code that tries to parse Lua errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allow finer control of input and debug output.
Closes #248