Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for windows with LuaJit #273

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

emcek
Copy link

@emcek emcek commented Oct 11, 2024

  1. Add Developer Command Prompt for Microsoft Visual C++.

This enables compile all needed libraries and successfully build wheels for both win_amd64 and win32 targets.

  1. Add test-command for windows to verify if module luajit21 was included in wheel

  2. restrict setuptools<72.0.0 due to test command has been removed, see more details:

  1. remove setuptools from Install dependencies step (for MacOS).

It was causing problems during building, when requirements.txt has setuptools with version restriction.

  1. Python 3.6 and 3.7 is not supported in Visual Studio 2019 image for AppVeyor

See: https://www.appveyor.com/docs/windows-images-software/#python

Related issues and PR: #235, #251

@emcek
Copy link
Author

emcek commented Oct 11, 2024

It looks to me appveyor is kind of redundant (and slow), but I leave decision to you what to do with it.

Changes are working in my fork and producing working wheels:

Copy link
Owner

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging through the failures here!

requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
@emcek
Copy link
Author

emcek commented Oct 17, 2024

Yeah, setuptools!=72.0.0 I've tried this and it doesn't work. Do not remember, but I think I try setuptools==72.1.0 as well and it didn't work.

pyproject.toml Outdated Show resolved Hide resolved
@emcek
Copy link
Author

emcek commented Oct 21, 2024

@scoder Looks like AppVeyor job is passing but doctest of README.rst not! Not sure it is related to newest setuptools since we block only 72.0.0, but with setuptools<72.0.0 it was working at 3dd2562

@emcek
Copy link
Author

emcek commented Oct 22, 2024

From logs, there is problem with importing lua54 but job is passing.

python -u -m lupa.tests.__main__
test (unittest.loader._FailedTest) ... ERROR
C:\projects\lupa\lupa\tests\..\..\README.rst
Doctest: README.rst ... FAIL
======================================================================
ERROR: test (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test
Traceback (most recent call last):
  File "C:\Python37-x64\lib\unittest\loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "C:\projects\lupa\lupa\tests\test.py", line 2368, in <module>
    @lupa.unpacks_lua_table
  File "C:\projects\lupa\lupa\__init__.py", line 90, in __getattr__
    lua = _newest_lib if _newest_lib is not None else _import_newest_lib()
  File "C:\projects\lupa\lupa\__init__.py", line 67, in _import_newest_lib
    _newest_lib = __import__(module_name[0], level=1, fromlist="*", globals=globals())
ModuleNotFoundError: No module named 'lupa.lua54'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants