Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/image attachment support #9

Merged
merged 22 commits into from
Apr 7, 2018
Merged

Feature/image attachment support #9

merged 22 commits into from
Apr 7, 2018

Commits on Jan 24, 2018

  1. added image attachment support

    @fracai
    fracai committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    69786b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. update to file dict description

    @fracai
    fracai committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    b8718ab View commit details
    Browse the repository at this point in the history

  2. context manage opening image attachment

    @fracai
    fracai committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    fd44aa9 View commit details
    Browse the repository at this point in the history

  3. updating type descriptions for image_path

    @fracai
    fracai committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    4fb6943 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. re-ordering imports

    @fracai
    fracai committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    47ca9b6 View commit details
    Browse the repository at this point in the history

  2. no need to pass in the "filename" to requests

    @fracai
    fracai committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    1be16c5 View commit details
    Browse the repository at this point in the history

  3. added my contribution credit

    @fracai
    fracai committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    19fd960 View commit details
    Browse the repository at this point in the history

  4. support for passing in file-like object as the attachment

    @fracai
    fracai committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    24806db View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. use six for 2/3 compatibility

    @fracai
    fracai committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    d15f584 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Fix image_path vs image argument name

    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    06e8f29 View commit details
    Browse the repository at this point in the history

  2. Add pathlib2 if running under python 2

    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    d798a61 View commit details
    Browse the repository at this point in the history

  3. Some cleanup of the logic of opening a path vs using a file-like. Als… 

    …o fix some docstrings
    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    872dfa1 View commit details
    Browse the repository at this point in the history

  4. Add pathlib2 to test dependencies for python 2.7 in tox

    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    5cc4e98 View commit details
    Browse the repository at this point in the history

  5. I screwed up the sign of my version comparison--replace >= with <

    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    4323b85 View commit details
    Browse the repository at this point in the history

  6. Add tests for the image attachment functionality

    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    569a7c0 View commit details
    Browse the repository at this point in the history

  7. Forgot pathlib wasn't introduced until 3.4

    @scolby33
    scolby33 committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    0e2c6e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Rearrange imports to put the try/except ones at the end

    @scolby33
    scolby33 committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    2f84bdd View commit details
    Browse the repository at this point in the history

  2. Use a smaller test image (67 bytes!)

    @scolby33
    scolby33 committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    a1bfc04 View commit details
    Browse the repository at this point in the history

  3. Remove extra None's in dict.get() calls

    @scolby33
    scolby33 committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    8235b3b View commit details
    Browse the repository at this point in the history

  4. Have getattr return an empty dict if the attr is missing here so `.ge… 

    …t` doesn't raise.
    @scolby33
    scolby33 committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    5caabff View commit details
    Browse the repository at this point in the history

  5. Factor out getting name out of Content-Disposition into a function.

    @scolby33
    scolby33 committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    66ae1dc View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2018

  1. Remove test for "bad image" upload since Pushover doesn't seem to do … 

    …any validation of the image contents.
    @scolby33
    scolby33 committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    0dd9424 View commit details
    Browse the repository at this point in the history