fix: potential xml type matching

scolladon · Jun 11, 2021 · bd494d3 · bd494d3
1 parent 47f4366
commit bd494d3
Showing 1 changed file with 22 additions and 7 deletions.
diff --git a/src/service/inFileHandler.js b/src/service/inFileHandler.js
@@ -23,16 +23,20 @@ const JSON_PARSER_OPTION = {
 }
 
 class InFileHandler extends StandardHandler {
+  static xmlObjectToPackageType
+
   constructor(line, type, work, metadata) {
     super(line, type, work, metadata)
     this.parentMetadata = this.metadata[this.type]
-    this.xmlObjectToPackageType = Object.keys(this.metadata)
-      .filter(meta => !!this.metadata[meta].xmlTag)
-      .reduce((acc, meta) => {
-        acc[this.metadata[meta].xmlTag] = this.metadata[meta]
+    this.xmlObjectToPackageType =
+      this.xmlObjectToPackageType ??
+      Object.keys(this.metadata)
+        .filter(meta => !!this.metadata[meta].xmlTag)
+        .reduce((acc, meta) => {
+          acc[this.metadata[meta].xmlTag] = this.metadata[meta]
 
-        return acc
-      }, {})
+          return acc
+        }, {})
   }
 
   handleAddition() {
@@ -82,7 +86,7 @@ class InFileHandler extends StandardHandler {
         subType = `${this.parentMetadata.directoryName}.${potentialType}`
       }
       const xmlTagMatchResult = line.match(XML_TAG)
-      if (!!xmlTagMatchResult && !!xmlTagMatchResult[1]) {
+      if (this._matchAllowedXmlTag(xmlTagMatchResult)) {
         potentialType = xmlTagMatchResult[1]
         fullName = null
       }
@@ -98,6 +102,17 @@ class InFileHandler extends StandardHandler {
     return toAdd
   }
 
+  _matchAllowedXmlTag(matchResult) {
+    return (
+      !!matchResult &&
+      !!matchResult[1] &&
+      Object.prototype.hasOwnProperty.call(
+        this.xmlObjectToPackageType,
+        matchResult[1]
+      )
+    )
+  }
+
   _treatInFileResult(toRemove, toAdd) {
     Object.keys(toRemove).forEach(type =>
       [...toRemove[type]]