Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration for Bot metadata #148

Merged
merged 13 commits into from
Jun 14, 2021
Merged

feat: add configuration for Bot metadata #148

merged 13 commits into from
Jun 14, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Add configuration data in metadata.json files
Add routing for the new configuration

Does this close any currently open issues?


closes #146

  • Jest test to check the fix is applied are added.

Any particular element to being able to test locally


Any other comments?


Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Mon May 3 20:41:19 PDT 2021; root:xnu-4903.278.68~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v14.16.0

git version: 2.31.1

sfdx version: sfdx-cli/7.102.0 darwin-x64 node-v14.16.0

sgd plugin version: 4.5.0

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #148 (c64c44f) into master (c580cfb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          18       18           
  Lines         402      403    +1     
=======================================
+ Hits          399      400    +1     
  Misses          3        3           
Impacted Files Coverage Δ
src/service/inResourceHandler.js 100.00% <ø> (ø)
src/service/typeHandlerFactory.js 100.00% <ø> (ø)
src/service/inFileHandler.js 100.00% <100.00%> (ø)
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)
src/service/waveHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c580cfb...c64c44f. Read the comment docs.

@scolladon scolladon requested a review from mehdicherf June 11, 2021 11:54
mehdicherf
mehdicherf previously approved these changes Jun 11, 2021
@scolladon scolladon requested a review from mehdicherf June 11, 2021 21:42
@scolladon scolladon changed the title feat: add configuration for Bot metadata 🔧 feat: add configuration for Bot metadata Jun 12, 2021
@codeclimate
Copy link

codeclimate bot commented Jun 14, 2021

Code Climate has analyzed commit c64c44f and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit fa60587 into master Jun 14, 2021
@scolladon scolladon deleted the fix/bot-metadata branch June 14, 2021 12:42
@scolladon scolladon mentioned this pull request Dec 9, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bot, BotVersion, and CorsWhitelist metadata types
2 participants