5.0.3 version introduced bug on document metadata

[arafesthain]

Issue verification check :

• does the current repository is fully deployable at the commit sha given to the from parameter of the command ?

What is the problem

Only document xml metadata is present inside a document folder in version 5.0.3

Expected Results (like in version 5.0.2)

Command used:
sfdx sgd:source:delta -d -t HEAD -f 2022_GR2.1_MARKETING -r /home/vsts/work/1/salesforce_repo -i /home/vsts/work/1/salesforce_repo/.forceignore -o output

[scolladon]

Hi @arafesthain

Thanks for raising this issue.
It is an issue with the new way to get diff from git not explicitly parsing binary file.

We will ship a new version very soon to fix this.

[scolladon]

Quick question here.

Imagine you just change the png file.
Per exemple just Action_Required.png

What do you expect to be able to deploy a delta generated sources from the plugin:

1. Just the png file (the actual behaviour of the plugin)
2. The png file and the associated document-meta.xml file (My local tests make me think it should be this)
3. The whole folder (I don't think so)

PR #271 ready for review/testing @arafesthain if you have time

[arafesthain]

Quick question here.

Imagine you just change the png file.
Per exemple just Action_Required.png

What do you expect to be able to deploy a delta generated sources from the plugin:

1. Just the png file (the actual behaviour of the plugin)
2. The png file and the associated document-meta.xml file (My local tests make me think it should be this)
3. The whole folder (I don't think so)

PR #271 ready for review/testing @arafesthain if you have time

Hi there, Thanks for the quick reply, point 2 for me :)
Don't remember if you put the steps somewhere to compile the package locally?

[scolladon]

Yes, we did add steps to run the plugin from sources here

[arafesthain]

@scolladon unable to pack sgd :')
yarn pack v1.22.18

$ rm -rf lib && tsc -b && oclif-dev manifest && oclif-dev readme
wrote manifest to C:\gitRepos\sgd\oclif.manifest.json
replacing <!-- commands --> in README.md
$ rm -f oclif.manifest.json ; prettier --write README.md
rm: unknown option -- write
Try 'rm --help' for more information.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/pack for documentation about this command.

Seems that there is a misleading command line interpretation on windows ?

[scolladon]

Have you tried to install the project first ?

$ yarn install

[arafesthain]

same error after running yarn install successfully.

[scolladon]

I think there maybe an issue with the globally installed version of prettier in your environment and the way we are prettifying the README.md

To unblock you just remove ; prettier --write README.md part of the postpack script in the package.json file

[arafesthain]

@scolladon GO for the pull request :) working fine from here

[scolladon]

Version 5.0.4 is just released with the fix for this issue