Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binary filtering for git diff --numstat parsing and document meta type file regression #271

Merged
merged 9 commits into from
Mar 22, 2022

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Mar 21, 2022

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Fix --numstat binary interpretation support when parsing git diff lines
Fix document meta file copy issue

Does this close any currently open issues?


closes #270

  • Jest test to check the fix is applied are added.

There is still an issue when changing an in Folder meta file, the corresponding file is not copied when the file extension is different

Any particular element to being able to test locally


Any other comments?


Next release

@scolladon scolladon requested a review from mehdicherf as a code owner March 21, 2022 23:58
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #271 (21e4693) into main (9e61b3f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          603       607    +4     
=========================================
+ Hits           603       607    +4     
Impacted Files Coverage Δ
src/utils/metadataConstants.js 100.00% <ø> (ø)
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/inResourceHandler.js 100.00% <100.00%> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)
src/utils/repoGitDiff.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e61b3f...21e4693. Read the comment docs.

@scolladon scolladon marked this pull request as draft March 22, 2022 00:09
@scolladon scolladon marked this pull request as ready for review March 22, 2022 00:37
src/service/standardHandler.js Outdated Show resolved Hide resolved
src/service/standardHandler.js Outdated Show resolved Hide resolved
@scolladon scolladon changed the title fix: binary filtering for git diff --numstat parsing fix: binary filtering for git diff --numstat parsing and document meta type file regression Mar 22, 2022
mehdicherf
mehdicherf previously approved these changes Mar 22, 2022
Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Mar 22, 2022

Code Climate has analyzed commit 21e4693 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 91c582c into main Mar 22, 2022
@scolladon scolladon deleted the fix/binary-diff branch March 22, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0.3 version introduced bug on document metadata
2 participants