Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xml header displayed twice for inFile delta generated #274

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Remove the duplicated xml header for in File delta generated

@scolladon scolladon requested a review from mehdicherf as a code owner March 22, 2022 21:00
@codeclimate
Copy link

codeclimate bot commented Mar 22, 2022

Code Climate has analyzed commit 25d33ad and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #274 (25d33ad) into main (24766a4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #274   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          607       607           
=========================================
  Hits           607       607           
Impacted Files Coverage Δ
src/service/inFileHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24766a4...25d33ad. Read the comment docs.

@scolladon scolladon merged commit bf1d278 into main Mar 23, 2022
@scolladon scolladon deleted the fix/customlabels-delta-generation branch March 23, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants