Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xml header displayed twice for inFile delta generated #274

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: xml header displayed twice for inFile delta generated #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/service/inFileHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const { XMLBuilder, XMLParser } = require('fast-xml-parser')
const FULLNAME = 'fullName'
const FULLNAME_XML_TAG = new RegExp(`<${FULLNAME}>(.*)</${FULLNAME}>`)
const XML_TAG = new RegExp(`^[${MINUS}${PLUS}]?\\s*<([^(/><.)]+)>\\s*$`)
const XML_HEADER = '<?xml version="1.0" encoding="utf-8"?>\n'
const XML_HEADER_TAG_END = '?>'
const XML_PARSER_OPTION = {
ignoreAttributes: false,
ignoreNameSpace: false,
Expand Down Expand Up @@ -80,8 +80,11 @@ class InFileHandler extends StandardHandler {
)
})
const xmlBuilder = new XMLBuilder(JSON_PARSER_OPTION)
const xmlContent = XML_HEADER + xmlBuilder.build(result.fileContent)
await outputFile(join(this.config.output, this.line), xmlContent)
const xmlContent = xmlBuilder.build(result.fileContent)
await outputFile(
join(this.config.output, this.line),
xmlContent.replace(XML_HEADER_TAG_END, `${XML_HEADER_TAG_END}\n`)
)
}

async _handleInDiff() {
Expand Down