Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter deletion for case insensitive file renaming #133

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains? Explain your changes.


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Filter from deletion "case only" file renaming

A	force-app/main/default/objects/Test__c/fields/ABC__c.field-meta.xml
D	force-app/main/default/objects/Test__c/fields/abc__c.field-meta.xml

Should generate only a package.xml (and not the destructiveChanges.xml) containing

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>Test__c.ABC__c</members>
        <name>CustomField</name>
    </types>    
    <version>50.0</version>
</Package>

Does this close any currently open issues?


closes #132

  • Jest test to check the fix is applied are added.

Any other comments?


Can be taken in any next release

Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Tue Jan 12 22:04:47 PST 2021; root:xnu-4903.278.56~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v14.16.0

git version: git version 2.31.1

sfdx version: sfdx-cli/7.94.3 darwin-x64 node-v14.16.0

sgd plugin version: sfdx-git-delta 4.3.2

@scolladon scolladon requested a review from mehdicherf April 20, 2021 13:14
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #133 (a449dd2) into master (ef45931) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   99.24%   99.25%           
=======================================
  Files          18       18           
  Lines         399      402    +3     
=======================================
+ Hits          396      399    +3     
  Misses          3        3           
Impacted Files Coverage Δ
src/utils/repoGitDiff.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef45931...a449dd2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming of a field name, SF case insensitiveness problem
2 participants