Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document extension handling #136

Merged
merged 6 commits into from
Apr 27, 2021
Merged

fix: document extension handling #136

merged 6 commits into from
Apr 27, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Improve regex creating the document metadata members
Let it deals with the volatility of the extension based on the type of the file hosting the change (it can be either the file extension or the meta file)

Improve test for inFolder element
Improve assertion in test handler helper

Does this close any currently open issues?


closes #135

  • Jest test to check the fix is applied are added.

Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Tue Jan 12 22:04:47 PST 2021; root:xnu-4903.278.56~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v14.16.0

git version: git version 2.31.1

sfdx version: sfdx-cli/7.98.0 darwin-x64 node-v14.16.0

sgd plugin version: sfdx-git-delta 4.4.0

@scolladon scolladon requested a review from mehdicherf April 26, 2021 16:47
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #136 (03a16c0) into master (ae44c14) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          18       18           
  Lines         402      402           
=======================================
  Hits          399      399           
  Misses          3        3           
Impacted Files Coverage Δ
src/service/inFolderHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae44c14...03a16c0. Read the comment docs.

@scolladon scolladon merged commit fea248c into master Apr 27, 2021
@scolladon scolladon deleted the fix/document-extension branch April 27, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The package.xml generated automatically appends the file extension in Document metadata type.
2 participants