Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: -d usage with -t different than HEAD #159

Merged
merged 10 commits into from
Jul 9, 2021

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Jul 2, 2021

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Move the current repository when config.to is different than HEAD
In order to have the file and the version of the file related to the commit wanted

Does this close any currently open issues?


Nop

  • Jest test to check the fix is applied are added.

Any particular element to being able to test locally


Use jest and node

Any other comments?


Need to be roughly tested and also we need to look for other way to do it better

Where has this been tested?


Operating System: Darwin Kernel Version 19.6.0: Thu May 6 00:48:39 PDT 2021; root:xnu-6153.141.33~1/RELEASE_X86_64

yarn version: 1.22.10

node version: v14.16.0

git version: 2.32.0

sfdx version: sfdx-cli/7.107.0 darwin-x64 node-v14.16.0

sgd plugin version: 4.61

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #159 (8416f0c) into master (9620574) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          418       433   +15     
=========================================
+ Hits           418       433   +15     
Impacted Files Coverage Δ
src/main.js 100.00% <100.00%> (ø)
src/utils/repoSetup.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9620574...8416f0c. Read the comment docs.

@scolladon scolladon requested a review from mehdicherf July 2, 2021 17:42
@scolladon
Copy link
Owner Author

@mehdisfdc we need to discuss about that, it is tricky and the actual solution is suboptimal to me

@scolladon scolladon force-pushed the fix/filecopy-to-not-latest-commit branch from ea4a23f to f3b32b5 Compare July 7, 2021 07:46
do not allow -d to be used with -t different of Head
@scolladon scolladon marked this pull request as ready for review July 7, 2021 14:30
src/main.js Show resolved Hide resolved
@scolladon scolladon force-pushed the fix/filecopy-to-not-latest-commit branch from 8493812 to 4af132a Compare July 7, 2021 14:36
src/main.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Mehdi Cherfaoui <mcherfaoui@salesforce.com>
@scolladon scolladon force-pushed the fix/filecopy-to-not-latest-commit branch from 3c11e28 to a2cd874 Compare July 7, 2021 15:52
@scolladon scolladon changed the title fix: handle sha git pointer navigation back and forth fix: -d usage with -t different than HEAD Jul 8, 2021
mehdicherf
mehdicherf previously approved these changes Jul 9, 2021
README.md Outdated Show resolved Hide resolved
Co-authored-by: Mehdi Cherfaoui <mcherfaoui@salesforce.com>
@codeclimate
Copy link

codeclimate bot commented Jul 9, 2021

Code Climate has analyzed commit 8416f0c and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 1a5ead0 into master Jul 9, 2021
@scolladon scolladon deleted the fix/filecopy-to-not-latest-commit branch July 9, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants