Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull request CI base commit #253

Merged
merged 3 commits into from
Feb 28, 2022
Merged

fix: pull request CI base commit #253

merged 3 commits into from
Feb 28, 2022

Conversation

scolladon
Copy link
Owner

And merging work when possible

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Use pull_request instead of pull_request_base
Issue is pull_request_base checkout the base branch which is not what we want to do.
In order to not have issue with external check using our credential those steps are not done from fork

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #253 (399c2d0) into main (ecd146f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          22       22           
  Lines         585      585           
=======================================
  Hits          577      577           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd146f...399c2d0. Read the comment docs.

And merging work when possible
@codeclimate
Copy link

codeclimate bot commented Feb 28, 2022

Code Climate has analyzed commit 399c2d0 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 163ee52 into main Feb 28, 2022
@scolladon scolladon deleted the fix/ci-base-commit branch February 28, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants