Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use more robust comparison for package.xml generation #279

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Use Intl.Collator method to sort package type and package member
Set the locale to french as it support accent

Does this close any currently open issues?


closes #278

  • Jest test added to check the fix is applied.

Any particular element that can be tested locally


Need windows and linux environment to make sure it works in both

Any other comments


Where has this been tested?


Operating System: Darwin Kernel Version 21.4.0: Mon Feb 21 20:34:37 PST 2022; root:xnu-8020.101.4~2/RELEASE_X86_64

yarn version: 1.22.15

node version: v14.19.0

git version: 2.35.1

sfdx version: sfdx-cli/7.143.0 darwin-x64 node-v14.19.0

sgd plugin version: 5.0.6

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #279 (6b5496d) into main (855cd84) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          613       614    +1     
=========================================
+ Hits           613       614    +1     
Impacted Files Coverage Δ
src/utils/packageConstructor.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855cd84...6b5496d. Read the comment docs.

@scolladon scolladon marked this pull request as draft March 28, 2022 17:47
@scolladon scolladon marked this pull request as ready for review March 29, 2022 18:56
@scolladon scolladon force-pushed the fix/package-ordering branch from 05d490e to be7ffb4 Compare March 30, 2022 12:31
@scolladon scolladon force-pushed the fix/package-ordering branch from be7ffb4 to 6b5496d Compare March 30, 2022 13:34
@codeclimate
Copy link

codeclimate bot commented Mar 30, 2022

Code Climate has analyzed commit 6b5496d and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon enabled auto-merge (squash) March 30, 2022 13:39
Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon merged commit f028375 into main Mar 30, 2022
@scolladon scolladon deleted the fix/package-ordering branch March 30, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.xml ordering different between Mac & Windows
2 participants