-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use more robust comparison for package.xml generation #279
Conversation
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 613 614 +1
=========================================
+ Hits 613 614 +1
Continue to review full report at Codecov.
|
05d490e
to
be7ffb4
Compare
be7ffb4
to
6b5496d
Compare
Code Climate has analyzed commit 6b5496d and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this pull request contain?
Explain your changes
Use
Intl.Collator
method to sort package type and package memberSet the locale to french as it support accent
Does this close any currently open issues?
closes #278
Any particular element that can be tested locally
Need windows and linux environment to make sure it works in both
Any other comments
Where has this been tested?
Operating System: Darwin Kernel Version 21.4.0: Mon Feb 21 20:34:37 PST 2022; root:xnu-8020.101.4~2/RELEASE_X86_64
yarn version: 1.22.15
node version: v14.19.0
git version: 2.35.1
sfdx version: sfdx-cli/7.143.0 darwin-x64 node-v14.19.0
sgd plugin version: 5.0.6