Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @salesforce/core missing dependency #812

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

scolladon
Copy link
Owner

Explain your changes


add @salesforce/core dependency explicitly

Does this close any currently open issues?


closes #804

@scolladon scolladon requested a review from mehdicherf as a code owner March 18, 2024 09:36
Copy link

codeclimate bot commented Mar 18, 2024

Code Climate has analyzed commit 7aa1bb3 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (71b1217) to head (7aa1bb3).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #812   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1041      1041           
  Branches       113       113           
=========================================
  Hits          1041      1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon changed the title fix: add @salesforce/core implicit dependency fix: add @salesforce/core missing dependency Mar 18, 2024
@scolladon scolladon merged commit fc3e5c9 into main Mar 18, 2024
20 of 21 checks passed
@scolladon scolladon deleted the fix/dependency-listing branch March 18, 2024 09:56
Copy link

Shipped in release v5.38.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.38.1

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleLoadError with latest sf due to missing @salesforce/core
1 participant