Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfolder anywhere #83

Merged
merged 9 commits into from
Jan 13, 2021
Merged

Subfolder anywhere #83

merged 9 commits into from
Jan 13, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains? Explain your changes.


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Bring sub folder to all the metadata supporting it
**/classes/controller/MyClass.cls-meta.xml
**/pages/view/MyPage.page-meta.xml
...

Does this close any currently open issues?


fix #79

  • Jest test to check the fix is applied are added.

Any other comments?


It is a big change.
The current status of the PR is not stabilized yet because it requires a lot of test to be written
The current test only ensure the previous feature are working, not the new feature

Where has this been tested?


Operating System: Darwin Kernel Version 18.7.0: Tue Nov 10 00:07:31 PST 2020; root:xnu-4903.278.51~1/RELEASE_X86_64

Yarn version: 1.22.10

Node version: v15.4.0

sgd version: 4.1.0

git version: 2.29.2

@scolladon scolladon requested a review from mehdicherf December 18, 2020 23:05
@scolladon scolladon changed the title Feature/subfolder anywhere Subfolder anywhere Dec 18, 2020
@scolladon scolladon force-pushed the feature/subfolder-anywhere branch from 28d5ef9 to d39c0ca Compare December 22, 2020 18:11
@scolladon scolladon marked this pull request as ready for review January 10, 2021 21:54
@scolladon scolladon merged commit 17f6766 into master Jan 13, 2021
@scolladon scolladon deleted the feature/subfolder-anywhere branch January 13, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hierarchical source sub folder globally
2 participants