Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type detection of EmailServicesFunction #831

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Flag EmailServicesFunction type to be detected only via directory.
As its file extension is too broad and this type cannot be located outside its folder

Does this close any currently open issues?


closes #830

  • Jest tests added to cover the fix.

@scolladon scolladon requested a review from mehdicherf as a code owner April 16, 2024 09:04
@scolladon scolladon changed the title Fix/emailservicesfunction type detection fix: type detection of EmailServicesFunction Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (de4cc73) to head (31b5c58).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #831   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1041      1042    +1     
  Branches       113       113           
=========================================
+ Hits          1041      1042    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Apr 16, 2024

Code Climate has analyzed commit 31b5c58 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon
Copy link
Owner Author

scolladon commented Apr 16, 2024

Hi @Enszula @bhushanpuri1991 @Sero030 !

Could you help with the QA of this PR please ?
It attempts to fix the issue with EmailServicesFunction type detection.
You can try locally following those steps

Help will be very much appreciated here :)
I'll merge it and ship a new release as soon as it is validated

@scolladon scolladon merged commit 8ac5518 into main Apr 17, 2024
7 of 21 checks passed
@scolladon scolladon deleted the fix/emailservicesfunction-type-detection branch April 17, 2024 07:37
Copy link

Shipped in release v5.38.3.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.38.3

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specificTestClasses is added incorrectly to EmailServicesFunction
1 participant