Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split scalajs-reactjs facade into -core and -dom modules #4

Closed
viktor-podzigun opened this issue Jun 17, 2021 · 0 comments
Closed

Split scalajs-reactjs facade into -core and -dom modules #4

viktor-podzigun opened this issue Jun 17, 2021 · 0 comments

Comments

@viktor-podzigun
Copy link
Collaborator

viktor-podzigun commented Jun 17, 2021 •
edited
Loading

Currently, scalajs-reactjs module contains both react and react-dom facades.

Its possible to use just react facade with other renderers such as react-native. So, we can extract core react facade into new scalajs-reactjs-core module and rename existing scalajs-reactjs module into scalajs-reactjs-dom (which will still contain react-dom facade) and make it depend on the -core module.
@viktor-podzigun viktor-podzigun changed the title Extract core react facade into scalajs-reactjs-core module Split scalajs-reactjs facade into -core and -dom modules Aug 24, 2021
viktor-podzigun added a commit that referenced this issue Aug 26, 2021
@viktor-podzigun
Fixed internal dependencies on -core and -dom modules (#4)
971323c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viktor-podzigun