-
Notifications
You must be signed in to change notification settings - Fork 391
[2.14.0] rsync path completion fails if a folder name have a space #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue is also present on Fedora with bash-completion 2.13 |
I bisected this and got the following:
(edited by @akinomyoga) Link to the commit: |
Here is a
|
This fixed it for me when modifying commit 9ba5831 :
|
Thanks for the report. The provided "fix" might appear to work, but it's accidental. The pair of the backslash and space appearing in The correct fix is to unquote |
@akinomyoga Thanks for the input. I'll be honest I'm not quite sure how to fix this in the current code. As things have changed a lot. Not sure if I have given you some ideas on how to fix it. I'll keep looking at it for a bit and see if I can figure things out. |
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java.
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Describe the bug
bash-completion was recently updated from 2.11.0 to 2.14.0 in Gentoo.
With bash-completion-2.14.0, rsync path completion fails if a folder name have a space.
To reproduce
with set -x
when I hit tab again (after the backslash is set) :
Versions
It isn't exclusive to Gentoo as I observe the exact same issue with Debian testing (Trixie) which features bash-completion-2.14.
On the other hand, with Debian stable (bookworm) and bash-completion-2.11, hitting tab correctly show the folders (with space or not)
Finally, downgrading bash-completion from 2.14.0 to 2.11.0 on my gentoo system solves the issue too.
The text was updated successfully, but these errors were encountered: