refactor(completions/*): apply API renaming #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
refactor-api-8
branch
from
5bfdb2c to
271ef2d
Compare
akinomyoga
changed the title
scop
approved these changes
Nov 14, 2023
The original two xfuncs (exported functions):
`_comp_xfunc_apt_cache_{sources,src_packages}` are merged into a
single generator interface: `_comp_xfunc_apt_cache_compgen_sources`.
The difference of the original two xfuncs seems to have been just the
former accepts `cur` (filtering prefix) as an argument while the
latter uses variable `cur` in the context. We do not need to prepare
such variations for generators because the filtering prefix is
externally specified to generators by `_comp_compgen -c cur`.
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
The last character of the variable can be obtained by simply ${var:
-1} from bash-2.0, so there is no need to use a helper function to
calculate the offset from the variable length.
The function is originally introduced in commit 8b23c84 as a
function named `__tar_last_char` along with many other functions, but
there does not seem to be specific reason for using the function to
get the last character of variables.
akinomyoga
force-pushed
the
refactor-api-8
branch
from
c89445f to
9faa669
Compare
|
rebased |
akinomyoga
force-pushed
the
refactor-api-8
branch
from
9faa669 to
bb1e4f9
Compare
Note: We remove the deprecated function `_comp_cmd_apt_get_installed_packages` because this function is introduced in commit ef1b97b (2020-11-07) after the latest release 2.11 (2020-07-25), i.e., this function has never been a part of the public interface in a released version. Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
akinomyoga
force-pushed
the
refactor-api-8
branch
from
bb1e4f9 to
3c7fe7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.