chore: Quote changelog lines with $.*{.*$
#1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
There are still other occurrences of raw $, which might better be quoted too for consistency, but it is not a big problem.
The CI error is caused by the change in #1090, which slipped off from the check due to some setup changes.
|
I guess the CI error should be fixed first in a separate PR. |
Yeah, made #1274 |
|
Can you rebase it to rerun the CI? |
yedayak
force-pushed
the
changelog-quote
branch
from
3e56c0e to
a8369f9
Compare
Done |
|
No problem with merging this, but as a sustainable solution, I'd rather have release-please (or our use of it) fixed to prevent issues like this, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1272