Fedoradev image: don't install vpnc, update for dnf5 #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
reviewed
Apr 10, 2025
| *) printf "%s\n" {/usr,}/{,s}bin/"$file" ;; | ||
| *) printf "%s\n" {/usr,}/bin/"$file" ;; |
There was a problem hiding this comment.
The commit message mentions "is being" and the related wiki page does not seem to mention the transition being complete. Is there any drawback from keeping sbin here still? If we remove it, do we lose any coverage?
There was a problem hiding this comment.
Removed this change for now
| esac | ||
| done | | ||
| xargs dnf --skip-broken -y install | ||
| done | grep -v vpnc | |
There was a problem hiding this comment.
Do we want to skip everything matching the string vpnc, or just some specific package? Maybe there's room for making the grep more specific here?
There was a problem hiding this comment.
Made it more specific, so we still test vpnc, just don't install vpnc-consoleuser
The path for the transaction history sqlite moved, the options have to be after the install subcommand
This still installs the vpnc command itself, which means we shouldn't actually lose coverage. Installing /usr/bin/vpnc brings vpnc-consoleuser, which then fails to install, see https://bugzilla.redhat.com/show_bug.cgi?id=2341517. Without this, I get conflicts about /usr/bin/vpnc and /usr/bin/vpnc-disconnect, between vpnc-consoleuser-0.5.3-48.svn550.fc41.x86_64 and vpnc-0.5.3-48.svn550.fc41.x86_64
yedayak
force-pushed
the
fedora-rawhide-fix
branch
from
35e9318 to
0a47c58
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vpnc causes this error: