docs: add SPDX license identifier #1391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related docs are not specific whether any amount of whitespace is acceptable before the id stanza, but I suppose it is. Going with more than one as it aligns better with the other commentary we have. * https://spdx.dev/learn/handling-license-info/#how * https://github.com/spdx/using/blob/17d56be4f4b99df87a52ae4a352810214707f861/docs/using-SPDX-short-identifiers-in-source-files.md Closes #1389
scop
commented
Jun 15, 2025
| @@ -19,6 +19,8 @@ | |||
| # along with this program; if not, write to the Free Software Foundation, | |||
| # Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
| # | |||
| # SPDX-License-Identifier: GPL-2.0-or-later | |||
There was a problem hiding this comment.
I did not bother adding this to every source file, I suppose it's good enough this way. But no objections if someone wants to add it to more files, it's just an oneliner anyway.
There was a problem hiding this comment.
If it is added to all files, I think the copyright notices should also be added to all files at least.
bash-completion/bash_completion
Lines 5 to 6 in 3ddb445
akinomyoga
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related docs are not specific whether any amount of whitespace is acceptable before the id stanza, but I suppose it is. Going with more than one as it aligns better with the other commentary we have.
Closes #1389