-
Notifications
You must be signed in to change notification settings - Fork 399
Analyze github workflows with zizmor #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In preparation for adding it to the pre-commit configuration.
26d7448 to
f86921c
Compare
457ef04 to
f86921c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, TIL & LGTM.
I've had the intention to work on this area and other security related things, looks like this will blend in nicely. One related thing I just submitted is #1433
|
One thing I will say about this is I would love to somehow test that releases will work correctly with this PR, is there a way to simulate the release please process somewhere? |
|
The first thing springing to mind is I guess you could tweak your own fork to do a release there. But as far as this PR is concerned, while that would be nice, I don't think that's required -- I hope I'll get to adding some other goodies which will require some eyeballing at release time anyway so I'll be aware. |
Without this it fails with this error: ``` Error: release-please failed: Resource not accessible by integration ``` The `issues: write` permissions are needed to create labels on PRs, because of this issue: https://github.com/orgs/community/discussions/156181 Followup to scop#1432
Without this it fails with this error: ``` Error: release-please failed: Resource not accessible by integration ``` The `issues: write` permissions are needed to create labels on PRs, because of this issue: https://github.com/orgs/community/discussions/156181 Followup to scop#1432
Without this it fails with this error: ``` Error: release-please failed: Resource not accessible by integration ``` The `issues: write` permissions are needed to create labels on PRs, because of this issue: https://github.com/orgs/community/discussions/156181 Followup to #1432
No description provided.