feat(__load_completion): don't hush errors or output when sourcing files #508
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We follow the message recent bash would output when sourcing a dir without letting bash to do it; doing so avoids fd leaks on some older but still supported bash versions. Other than that, let all output from sourcing the file pass through to ease debugging. Refs #506
scop
force-pushed
the
feat/dont-hush-source-output
branch
from
964ba2e
to
245b448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We follow the message recent bash would output when sourcing a dir
without letting bash to do it; doing so avoids fd leaks on some older
but still supported bash versions. Other than that, let all output from
sourcing the file pass through to ease debugging.
Closes #506