chore(pre-commit/update-deprecated-links): exclude untracked files #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
reviewed
Feb 23, 2023
akinomyoga
force-pushed
the
update-deprecated-links
branch
from
6f1ce19 to
3bbd5d7
Compare
scop
approved these changes
Feb 23, 2023
akinomyoga
force-pushed
the
update-deprecated-links
branch
from
3bbd5d7 to
e8b3b17
Compare
The pre-commit script `update-deprecated-links` creates dangling links to untracked files (such as the text editor's backup files, the manually backed up files, some files that will be added later, etc.). These dangling links would block creating the commit. In this patch, we check if the target path is tracked by git or not before creating the symbolic link. We also would not try to remove untracked files or regular files in `test/deprecated/completions/`. We would only remove tracked links.
The test scripts have had the shebang #!/bin/bash, but Bash is not necessarily located at /bin/bash. For example, it does not located there in FreeBSD and MINIX. As we require /bin/bash in the shebang of the pre-commit scripts, any attempts to commit changes in such a system would be blocked by the pre-commit hook. In this patch, we update the shebang to `#!/usr/bin/env bash`, which is a widely used workaround for this issue. Note: I have not changed the shebang of `test/docker/*/install-packages.sh` as these seem to be always called in a GNU/Linux container, where /bin/bash exists.
akinomyoga
force-pushed
the
update-deprecated-links
branch
from
e8b3b17 to
820b613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description is in the commit message 3657334.