Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support container file mode #92

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

astromechza
Copy link
Member

Up until now we were ignoring the container file mode bits. This PR fixes that, we now allow the file mode to be set on the file as an octal number.

The restrictions are:

  1. must always be readable by the owner (> 0400)
  2. if the owner does not have write permissions, we enable read only on the bind mount itself
  3. otherwise any other file mode that works is accepted.
  4. cannot be > 0777

@astromechza astromechza linked an issue Mar 20, 2024 that may be closed by this pull request
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astromechza astromechza merged commit f14133d into main Mar 20, 2024
3 checks passed
@astromechza astromechza deleted the 88-feature-request-support-containersfilesmode branch March 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support containers.*.files[*].mode
3 participants