fixed OCI image import bug #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
mathieu-benoit
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Super great, thanks a bunch for your hard work on this, @7h3-3mp7y-m4n!
Adding more tests, actually testing the content of 3 methods (git, oci and https) is really neat!
LGTM for me.
Please, @astromechza, over to you for your review, thanks!
astromechza
reviewed
Oct 30, 2024
astromechza
reviewed
Oct 30, 2024
astromechza
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Juse a couple of requests, but otherwise this looks good so far @7h3-3mp7y-m4n
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
astromechza
approved these changes
Nov 1, 2024
|
@7h3-3mp7y-m4n anything else here, or can I merge this for you? |
No @astromechza , You can merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's an attempt to solve the issue faced by getOci
What does this PR do?
this PR added a new logic as said to retrieve the file and return it
Types of changes
Checklist: