Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fixes #1077 : 'Add Images' button workings and Image Drawer Bug fixed ] #1158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohitPandey469
Copy link

@rohitPandey469 rohitPandey469 commented Feb 2, 2024

Description

In the ImageDrawer component, I addressed an issue where the file input was not triggering the beforeUpload function, leading to the failure of the subsequent uploadTutorialImages actions. To resolve this, I added an onChange event to the image input. And then,

In the uploadTutorialImages actions, the checkUserOrOrgHandle function was not functioning correctly due to mismatches in the parameters passed to checkUserHandleExists and checkOrgHandleExists. These functions were expecting Firebase, but Firestore was being provided. I fixed this.

Additionally, in the checkUserHandleExists actions, the code was searching for the owner in the cl_user_handle collection, which did not exist. I modified it to search in the cl_user collection and verified the owner's existence based on the IDs.

While fixing I thought at some point that the problem is with Snackbar component so I changed it too in the ImageDrawer component which I had already done in PR #1141 ( just copying and pasting from there and then the new code).

Related Issue

Fixes #1077

Motivation and Context

The Image Drawer component wasn't being used properly so fixed it, now it looks more cool.

How Has This Been Tested?

Tested locally on my machine. See the video

Video demonstrating the current functionality of the Add Images button:

Codelabz.-.Google.Chrome.2024-02-02.14-31-16.mp4

Here selecting images from other window, my screen recorder didn't shown it!!!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feat : Display Selected Images via "Add Image" Btn. in QuillEditor ]
1 participant