-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created get_tweets.py which modularizes the code from all .py files #526
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this pr complete @ov1n ??
check if changes to get__tweets.py work for adaderana handler
@Anmolbansal1 changed only the |
@ov1n The changes looks good, kindly attach screenshots showing correctness of these changes. If it's properly working, apply it to all crawlers in tweets. Overall nice work, cheers 💯 |
@Anmolbansal1 yes sure,thanks but having some difficulties in running flask currently after I rebuilt , looks like dependancy errors. hoping for some instructions |
Looks like flask_cors is not installed. But it's present in requirements file. Have you installed all requirements.txt?? And the virtual environment is active?? |
everything is active,I even used a seperate .txt and installed flask-cors but no luck , however the requirement typed-ast==1.2.0 wasn't installed. This was the only requirement that gave an error. |
@ov1n You may open an issue regarding this fix with all logs so we can discuss it. Meanwhile for this pr, as it is about crawling just apply it to all twitter crawlers and attach screenshots showing it's working |
Please provide enough information so that others can review your pull request:
The functions get_all_tweets(screen_name) and save_es(outtweets, es) were declared in the above mentioned
get_tweets.py
.Explain the details for making this change. What existing problem does the pull request solve?
Code redundancy in all other crawler files.
So
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
The
get_tweets
header will be imported into all other crawler files.Code formatting
Closing issues
Put
closes #XXXX
in your comment and commit message to auto-close the issue that your PR fixes (if such).