Laser Layout Mirror Option #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For material where the outside face of the design is cut facing *up* rather than down.
One function call with children instead of a separate call for each child
This avoids etching on the outside faces when the layout is mirrored. Note that this commit breaks the `generate_2d.py` script when using the --mirror option, as etchings will fail to export.
This allows you to disable geometry (like etched features) and have the script ignore cases where no geometry is exported.
|
Okay. With the addition of the alignment indicators (PR #111) I think we've reached the point where it no longer makes sense to mirror the individual etched portions. Instead, I've updated the etch function to prevent rendering the laser etches if the mirror option is set. I've also updated the Demos: |
scottbez1
reviewed
Dec 24, 2020
This simplifies the logic when disabling the etched output.
scottbez1
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to mirror the 2D laser-cut design so that the outside faces are facing 'up' / towards the laser when cut. This is useful for materials with a special finish on only one side like Ponoko's matte black acrylic, which is cut with the matte finish facing towards the laser.
The mirroring can be set with the
render_2d_mirrorflag, or with the--mirroroption in thegenerate_2d.pyscript.This continues the conversation from PR #100, and offers an alternate solution to the same issue.