Cleanup sense_link code and fix W1201 warning #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Sep 9, 2023
| self.transport.sendto(encrypted_resp, addr) | ||
| else: | ||
| # Do not send response, but log for debugging | ||
| logging.debug(f"SENSE_RESPONSE disabled, response content: {response}") | ||
| _LOGGER.debug("SENSE_RESPONSE disabled, response content: %s", response) |
There was a problem hiding this comment.
This was converting the json payload to a string and than throwing it away if debug logging was not enabled
bdraco
commented
Sep 9, 2023
| else: | ||
| logging.debug(f"Ignoring non-emeter JSON from {addr}: {json_data}") | ||
| _LOGGER.debug(f"Ignoring non-emeter JSON from %s: %s", addr, json_data) |
There was a problem hiding this comment.
This was converting the response payload to a string and than throwing it away if debug logging was not enabled
bdraco
commented
Sep 9, 2023
| # Strip leading 4 bytes for...some reason | ||
| encrypted_resp = encrypted_resp[4:] | ||
|
|
||
| # Allow disabling response | ||
| if self.should_respond: | ||
| # Send response | ||
| logging.debug(f"Sending response: {response}") | ||
| logging.debug("Sending response: %s", response) |
There was a problem hiding this comment.
This was converting the response payload to a string and than throwing it away if debug logging was not enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/logging-not-lazy.html