Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http-basic-auth via basicAuth setting #47

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 12, 2016

use settings.basicAuth.username and settings.basicAuth.password to
configure basic authentication.

@staabm
Copy link
Contributor Author

staabm commented Jul 12, 2016

see #36 (comment)

basic_auth: settings.basicAuth ? {
user: settings.basicAuth.username,
pass: settings.basicAuth.password
} : null,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either break before the operators:

        basic_auth: settings.basicAuth
            ? {
                user: settings.basicAuth.username,
                pass: settings.basicAuth.password
            }
            : null

Or invert the conditional:

        basic_auth: !settings.basicAuth ? null : {
            user: settings.basicAuth.username,
            pass: settings.basicAuth.password
        }

And drop the trailing comma.

@scottgonzalez
Copy link
Owner

Thanks, this still needs docs.

use settings.basicAuth.username and settings.basicAuth.password to
configure basic authentication.
@staabm
Copy link
Contributor Author

staabm commented Jul 12, 2016

@scottgonzalez documented the new options and adjusted CS per review

@scottgonzalez
Copy link
Owner

Released in v1.3.0.

@staabm staabm deleted the basicauth branch July 12, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants