Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 swagger-ui-dist to latest version #193

Closed
wants to merge 4 commits into from

Conversation

BePo65
Copy link

@BePo65 BePo65 commented Jun 9, 2020

Solves issue #185.

Unable to run tests on my machine (windows 10; node 14.4.0).

@yinzara
Copy link

yinzara commented Jun 23, 2020

3.27 is out and this PR isn't yet merged. Can we get it changed to 3.27?

3.27 includes swagger-api/swagger-ui#6037

@BePo65
Copy link
Author

BePo65 commented Jun 27, 2020

swagger-ui version 3.27 runs also fine.

@BePo65
Copy link
Author

BePo65 commented Jun 27, 2020

how about also switching from phantomjs to puppeteer as phantomjs is deprecated for more than 2 years (see phantomjs on github)?
PR #196 would solve this issue.

@yinzara
Copy link

yinzara commented Jul 15, 2020

@scottie1984 Any chance we could get a release with this?

@tan-dd
Copy link

tan-dd commented Oct 7, 2020

Why is not this PR getting merged? 3.35 is out as well

@tanmoy-git
Copy link

I have published this package with the updated swagger-ui-dist version. You may use it alternatively to enjoy the latest offerings by Open API 3 : https://www.npmjs.com/package/swagger-ui-express-updated

npm i swagger-ui-express-updated

@kevinccbsg
Copy link

Hi @scottie1984 Any chance we could get a release with this?

@BePo65 BePo65 force-pushed the bepo65/updatePackage branch from 6e3b3d8 to 7953d84 Compare February 23, 2021 09:28
@mentatxx
Copy link

This patch is not really needed - you can just upgrade packages.
By fresh install i'm getting 3.45.0 with original ^3.18.1 version specifier

{
  "_from": "swagger-ui-dist@^3.18.1",
  "_id": "swagger-ui-dist@3.45.0",

@BePo65
Copy link
Author

BePo65 commented Mar 22, 2021

You are right (of course :-). I deleted my 'node_modules' folder and the 'package-lock.json' file and then reinstalled the packages with npm i and voila the 'swagger-ui-dist' was updated to V3.45.1.

So I close this pr as being unnecessary.

@BePo65 BePo65 closed this Mar 22, 2021
@BePo65 BePo65 deleted the bepo65/updatePackage branch March 22, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants