[39] Implement DELETE /api/cameras/<uuid>/<stream>/view.mp4?s=X-Y to delete whole recordings #323
Conversation
…delete whole recordings
| @@ -506,6 +507,38 @@ Bugs and limitations: | |||
| `hasTrailingZero` above, and | |||
| [#178](https://github.com/scottlamb/moonfire-nvr/issues/178). | |||
|
|
|||
| ### `DELETE /api/cameras/<uuid>/<stream>/view.mp4` | |||
There was a problem hiding this comment.
While
DELETE /api/cameras/.../.../view.mp4is a little strange, givenGET view.mp4does a live transformation to MP4 to justify its name, I do like theDELETEendpoint is guessable from theGETendpoint.
Yeah, that name is a bit strange. The guessability is nice but hopefully not too important when we have these API docs.
My first thought is that maybe this should be a POST to /recordings. We also should take in the csrf parameter for this as we do for other non-GET stuff, and that gives us a place to put it in a similar format, and to attach more preconditions and such if desired. What do you think?
There was a problem hiding this comment.
csrf is a good callout. Will update.
Is there a sub-path of POST /api/camera/.../.../recordings/XYZ that could work? Or POST /api/camera/.../.../XYZ?
|
Ready for another pass |
…ure garbage propagates" This reverts commit 8350805.
…ing but runStartId..endId results in panics
breel-dev
force-pushed
the
breel-dev/39-DELETE-recording
branch
from
5dbf8cc
to
0535c3a
Compare
|
Ran into warnings about already deleted files and panics over missing garbage. Have not resolved. |
#39
Continuous garbage collection only seems to start from
server/db/writer.rs#delete_oldest_recordings. I don't want to delete "enough old recordings to be within disk restrictions" without pruning the API deleted recordings first. I made theLockedDatabase::delete_recordings()also re-initialize theSampleFileDirs'garbage_needs_unlinkcollections.While
DELETE /api/cameras/.../.../view.mp4is a little strange, givenGET view.mp4does a live transformation to MP4 to justify its name, I do like the DELETE endpoint is guessable from the GET endpoint.